Keyboard shortcuts - Added Selection: Flip and adjusted Display: Flip #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J5lx
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Two small adjustments I’ve made:
- Replaced display with view, in line with the main menu
- Reverted the change to the internal name of the display flip shortcuts (CmdFlip…). While it’s good to distinguish those shortcuts in the UI, these internal names are never seen by users and changing them effectively causes the shortcuts to be reset to their default if they were previously customised by the user.
Other than that, LGTM. Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed "Horizontal Flip" and "Vertical Flip" since they only applied to the display. I figured that might be confusing for the user so I just renamed them as "Display: Horizontal/Vertical Flip" and then added the "Selection: Horizontal/Vertical Flip" separately so the user can set those two separately.